@VanessaScherma Thanks for the PR. A very top-level review.

What works:

1. Saving of skeletal DT in the gitlab repository

What does not work:

1. The newly created DT does not show up in Manage and Execute pages
2. The new DT is not shown even after restarting the client and also not after relogin

What are the suggested improvements:

1. Have a field for name of DT
2. Permit users to save DTs even if the files are empty

@prasadtalasila

The DT created should be immediately visible within the page, as shown in these screenshots:



In the example shown, I created a digital twin called ‘testDT’, correctly created as informed by the Snackbar at the bottom of the page after confirming the save. As soon as I changed tabs to Manage, it was immediately visible.

Regarding suggestions, I can move the field for the DT name from the Dialog to above the Editor, so that it is always visible. For empty files, on the other hand, I had initially left this option but a problem had arisen with Editor Monaco. In fact, if the file is empty, the text shown on EditorTab cannot be updated, showing the contents of the previously selected file. This is probably due to the ‘read-only’ option I added to avoid writing without having selected a file first. I can look for some alternative solution if you think the possibility of creating empty files is more suitable.

@VanessaScherma

In the example shown, I created a digital twin called ‘testDT’, correctly created as informed by the Snackbar at the bottom of the page after confirming the save. As soon as I changed tabs to Manage, it was immediately visible.

Strange. I've created two new DTs, namely "new-dt" and "new-digital-twin". But they don't show up in Manage and Execute tabs.

Regarding suggestions, I can move the field for the DT name from the Dialog to above the Editor, so that it is always visible.

Ok thanks

For empty files, on the other hand, I had initially left this option but a problem had arisen with Editor Monaco. In fact, if the file is empty, the text shown on EditorTab cannot be updated, showing the contents of the previously selected file. This is probably due to the ‘read-only’ option I added to avoid writing without having selected a file first. I can look for some alternative solution if you think the possibility of creating empty files is more suitable.

It is alright for now. Please focus on completing the PR.

Code Climate has analyzed commit 28c38a7 and detected 3 issues on this pull request.

Here's the issue category breakdown:

View more on Code Climate.

The correct dependency graph is:

DigitalTwin (create, reconfigure, execute) ---> GitlabInstance (files, commits, jobs etc)
         |                                                        ^
         |                                                        |
         |----> Files (create, update, delete) -------------------|

You can create an interface IFiles and then have both GitlabInstance and Files implement this interface.

The current code structure requires addition of child pipeline in parent pipeline. Thus each new DT created must have an entry in top-level .gitlab-ci.yml. Otherwise, the execution of new DTs fails.

The solution is to have the create step has update the .gitlab-ci.yml at the root-level. Otherwise, the new DTs do not get executed.

The correct dependency graph is:

DigitalTwin (create, reconfigure, execute) ---> GitlabInstance (files, commits, jobs etc)
         |                                                        ^
         |                                                        |
         |----> Files (create, update, delete) -------------------|

You can create an interface IFiles and then have both GitlabInstance and Files implement this interface.

This is how the code was refactored:
The methods concerning files, previously placed in the DigitalTwin class, have now been moved to a FileHandler class. This class implements the IFiles interface. Each DigitalTwin has a FileHandler among its attributes, and initialises it in the constructor by passing it the same GitlabInstance associated with the DigitalTwin, which is used to call the APIs.

The only reference to files still present in DigitalTwin are the attributes descriptionFiles, configFiles, lifecycleFiles, since they are the file names closely related to the DT.

@prasadtalasila
The handling of the .gitlab-ci.yml file is resolved. When a new DT is created, a trigger_DTName section is added to the .gitlab-ci.yml file in the parent pipeline. Similarly, this section is removed when deleting the corresponding DT from the Manage tab.

@VanessaScherma please rebase the PR

@VanessaScherma The addition of new DT adds entries in top-level .gitlab-ci.yml but the format is incorrect. As a result, an execution request on new DT triggers the following error.

The matching lines are:

The create request is adding extra tabs at the beginning of new lines. Could this be the error?

another consequence is that the execution of existing DTs fail as well due to syntax error in top-level .gitlab-ci.yml.

@VanessaScherma Apparently the tests inside and outside of test/preview folder are interacting. I've deleted the test/preview directory and ran yarn test:unit and yarn test:int. Please see the results in the log file.
test-log.log

@prasadtalasila

I made a small modification to the jest.setup.ts of the integration code. Now, if the REACT_APP_AUTH_AUTHORITY is not found, it is inserted. The tests are successfully executed.

However, the 'Run client unit and integration tests' job fails with the yarn test:int command for low code coverage, as my files are covered by the yarn test:preview:int command. Is there a way to count the coverage using the two commands together?